Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added SystemSofastFixed #78

Merged
merged 28 commits into from
Apr 17, 2024
Merged

added SystemSofastFixed #78

merged 28 commits into from
Apr 17, 2024

Conversation

braden6521
Copy link
Collaborator

  • Renamed old SystemSofastFixed to PatternSofastFixed (analog of SofastFringe Fringes.py class)
  • Created new SystemSofastFixed (analog of SystemSofastFringe)
  • Pulled all of these together into a Sofast command line interface (/contrib/app/sofast/)

@braden6521 braden6521 marked this pull request as draft April 10, 2024 18:50
@braden6521 braden6521 self-assigned this Apr 10, 2024
@braden6521 braden6521 force-pushed the run_sofast_fixed branch 2 times, most recently from a1ee9f7 to 8ec83b1 Compare April 10, 2024 20:30
@braden6521 braden6521 marked this pull request as ready for review April 10, 2024 21:10
@braden6521 braden6521 requested a review from bbean23 April 10, 2024 21:11
bbean23
bbean23 requested changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@bbean23 bbean23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I have just a few comments. Please address them and I'll approve.

contrib/app/sofast/sofast_command_line_interface.py Outdated Show resolved Hide resolved
contrib/app/sofast/sofast_command_line_interface.py Outdated Show resolved Hide resolved
contrib/app/sofast/sofast_command_line_interface.py Outdated Show resolved Hide resolved
contrib/app/sofast/sofast_command_line_interface.py Outdated Show resolved Hide resolved
opencsp/app/sofast/lib/SystemSofastFixed.py Show resolved Hide resolved
opencsp/app/sofast/lib/SystemSofastFixed.py Outdated Show resolved Hide resolved
opencsp/app/sofast/test/ImageAcquisition_no_camera.py Show resolved Hide resolved
@braden6521
Renamed SystemSofastFixed to PatternSofastFixed and updated files and…
97b42fb 
… unit tests
@braden6521
Added SystemSofastFixed class.
37b48ec
@braden6521
Added test_SystemSofastFixed unit test and updated ImageAcquisition_n…
9642447 
…o_camera.
@braden6521
Renamed SystemSofastFixed to PatternSofastFixed and updated files and…
0da37ab 
… unit tests
@braden6521
Added SystemSofastFixed class.
e255db5
@braden6521
Added test_SystemSofastFixed unit test and updated ImageAcquisition_n…
0d0398e 
…o_camera.
@braden6521
Renamed SystemSofastFixed to PatternSofastFixed and updated files and…
6847f02 
… unit tests
@braden6521
Added SystemSofastFixed class.
f1d6101
@braden6521
Added test_SystemSofastFixed unit test and updated ImageAcquisition_n…
d1f8cbb 
…o_camera.
@braden6521
Added DistanceOpticScreen to SystemSofastFixed.
1df7a89
@braden6521
Added Singleton/Multidon image acquisition/projection support to Syst…
a6fed12 
…emSofastFixed.
@braden6521
Added sofast command line interface
aeb8d7b
@braden6521
Added sofast command line interface
b62e50a
@braden6521
Added run_next to sofast_cli
beb227a
@braden6521
Added Fixed functionality to Sofast CLI
6d970a5
@braden6521
Removed calibrate camera exposure from SystemSofastFixed
db99aea
@braden6521
Removed debugging lines from sofast CLI. Aded more functionality.
da153ff
@braden6521
Removed obsolete run_and_characterize sofast scripts.
416aa2d
@braden6521
Updated contrib Sofast readme
41d25dc
@braden6521
Updated SystemSofastFixed unit test.
48a9b12
@braden6521
Made black happy
4e76b7c
@braden6521
Changed how SystemSofastFixed closes.
0d65611
@braden6521
Fixed too short of documentation underline
f237d92
@braden6521
Copy link
Collaborator Author

@bbean23, thanks for comments! I believed I have addressed them all.

bbean23
bbean23 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@bbean23 bbean23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved!

@braden6521 braden6521 merged commit 5e9bd30 into sandialabs:develop Apr 17, 2024
4 checks passed
@braden6521 braden6521 deleted the run_sofast_fixed branch April 17, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbean23 bbean23 bbean23 approved these changes

Assignees

@braden6521 braden6521

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braden6521 @bbean23