60 sofast curl interface #75
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braden6521
reviewed
Apr 9, 2024
opencsp/app/sofast/__init__.py
Outdated
There was a problem hiding this comment.
To add:
- SpatialOrientation
- DisplayShape
- DotLocations
- FacetDefinition (EnsembleDefinition if we want to support facet ensembles now)
- Surface 2D definition
…ethods to MirrorPoint, add load_from_hdf_guess_type to Surface2DAbstract, improved hdf5 comments
bbean23
force-pushed
the
60-sofast-curl-interface
branch
from
2194b7c
to
ef46859
Compare
…, fix a ton of bugs
…est_collect_fringe_from_other_thread, add _on_tick handler for Executor
sensitive_strings_allowed_binary_files_20240412_144750.csv
e10harvey
reviewed
Apr 25, 2024
| + f"It is suggested that you restrict outside access to port {port} of the host computer." | ||
| ) | ||
| lt.info(f"Starting server on port {port}...") | ||
| server = HTTPServer(("0.0.0.0", port), SofastServer) |
There was a problem hiding this comment.
Consider storing "0.0.0.0" as a local variable above near where port is defined.
There was a problem hiding this comment.
Yep, this is a good idea and one I will implement.
Hey, sorry about the confusion. This PR isn't ready for review yet (if I assigned you already that was a mistake). I'll let you know when it is ready.
| # The minimum time between server evaulation loops is determined by the GIL: | ||
| # https://docs.python.org/3/library/sys.html#sys.setswitchinterval | ||
| server_pool = ThreadPoolExecutor(max_workers=1) | ||
| server_pool.submit(server.serve_forever) |
There was a problem hiding this comment.
What happens if this thread crashes or throws an exception? Will the program exit cleanly?
There was a problem hiding this comment.
This is a valid concern and actually why I'm doing this work. The intent is to have a separate program that restarts the entire process if the server stops responding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.