Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

160 clean up abstractspotanalysisimageprocessor #162

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

160 clean up abstractspotanalysisimageprocessor #162

wants to merge 34 commits into from

Conversation

bbean23
Copy link
Collaborator

@bbean23 bbean23 commented Aug 20, 2024

This PR is a biggie. It includes:

  • combining AbstractSpotAnalysisImageProcessor and it's ...Leger class
  • moving much of the cacheing logic to CacheableImage
  • adding lots of tests
  • code cleanup and documentation

braden6521 and others added 30 commits August 9, 2024 13:47
@braden6521
Removed legacy measurement data from DistanceOpticScreen and updated …
68e95e8 
…documentation.
@braden6521
Udated documentation and fixed prefix in AbstractMeasurementSofast
ecfce48
@braden6521
Udated documentation and fixed prefix in MeasurementSofastFixed
0131967
@braden6521
Udated documentation and fixed prefix in MeasurementSofastFringe
c5d2251
@braden6521
Updated unit test Sofast measurements.
67da2ef
@braden6521
Merge pull request sandialabs#131 from braden6521/unified_sofast_meas…
796417b 
…urement

Standardize Sofast measurement HDF format
@bbean23
add "_original_two_points" property in order to be able to tell the d…
7454908 
…ifference between positive and negative infinity in the slope
@bbean23
add angle()/from_rho_theta()/from_location_angle() methods to LineXY
04713dc
@bbean23
fix LineXY.from_rho_theta(), update to match definition from OpenCV H…
8ec7a36 
…ough Transforms
@bbean23
add test for LineXY.from_location_angle()
2c42308
@bbean23
Merge pull request sandialabs#150 from bbean23/143-expand-linexy-cons…
61451fe 
…tructors-and-slope-information

143 expand linexy constructors and slope information
@bbean23
add "large_data_example_dir" settings option in addition to the exist…
f9040c0 
…ing "example_dir" option
@bbean23
reword settings structure to use the python built-in ini config parser
8194ea6
@bbean23
fix test_opencsp_root_path
e9f821a
@bbean23
Merge pull request sandialabs#152 from bbean23/151-differentiate-betw…
455d425 
…een-example-data-and-large-data-paths

151 differentiate between example data and large data paths
@bbean23
combine AbstractSpotAnalysisImageProcessor and AbstractSpotAnalysisIm…
6bd3fef 
…ageProcessorLeger
@bbean23
move cacheing functionality from AbstractSpotAnalysisImageProcessor t…
7543d43 
…o CacheableImage
@bbean23
add process_images() method to AbstractSpotAnalysisImageProcessor
201c518
@bbean23
add unit tests for CacheableImage.__init__(), fix __init__()
8ca885f
@bbean23
fix CacheableImage._register* by making it static instead of a class …
cc78c54 
…method
@bbean23
add test for CacheableImage memory usage
cf45d16
@bbean23
remove unnecessary CacheableImage.cached field, better docstrings
9e90525
@bbean23
small fixes and code cleanup
ded0e87
@bbean23
add test_CacheableImage.test_cache() method, fix CacheableImage.cache…
736d4b8 
…() method
@bbean23
better behavior for CacheableImage properties
018cd71
@bbean23
fix CacheableImage.cache(), test CacheableImage.lru()
0295fb5
@bbean23
forgot input data for the CacheableImage tests
3d47840
@bbean23
add most basic test for AbstractSpotAnalysisImageProcessor
e71e26d
@bbean23
whoops that's not supposed to be here yet
ae7cdce
@bbean23
add test_AbstractSpotAnalysisImageProcess.test_finished()
068f9a1
@bbean23 bbean23 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Aug 20, 2024
@bbean23 bbean23 self-assigned this Aug 20, 2024
@bbean23 bbean23 marked this pull request as ready for review September 9, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e10harvey e10harvey Awaiting requested review from e10harvey

@braden6521 braden6521 Awaiting requested review from braden6521

At least 1 approving review is required to merge this pull request.

Assignees

@bbean23 bbean23

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbean23 @braden6521