Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

148 even more drawing options #155

Merged
merged 20 commits into from
Sep 6, 2024
Merged

148 even more drawing options #155

merged 20 commits into from
Sep 6, 2024

Conversation

bbean23
Copy link
Collaborator

@bbean23 bbean23 commented Aug 10, 2024 •
edited
Loading

Easy win:

  • lots of documentation
  • lots of tests

Other stuff:

  • Better color handling in Color, RenderControlText, and RenderControlPointSequence
  • View3d.draw_heatmap_2d()
  • View3d.draw_pq_list(gradient='viridis')
  • View3d.draw_image() options

@bbean23 bbean23 added the enhancement New feature or request label Aug 10, 2024
@bbean23 bbean23 self-assigned this Aug 10, 2024
braden6521
braden6521 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@braden6521 braden6521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good @bbean23!

@bbean23
fix View3d.draw_image() method and add extra options for where and ho…
cdac260 
…w to draw the image
@bbean23
reorder test_View3d tests to match the order of methods in View3d
1db481b
@bbean23
add documentation for RenderControlText, fix text rotation to be in r…
550f404 
…adians, add test for draw_pq_text()
@bbean23
add documentation for draw_xyz_text, fix rotation to be measured in r…
9054aa4 
…adians, add unit test
@bbean23
standardize colors in RenderControlPointSequence and in RenderControl…
7d7f8be 
…Text, add alpha option for markers
@bbean23
test the various rendering options for RenderControlPointSequence
00de046
@bbean23
add method View3d.draw_heatmap_2d()
e6b0441
@bbean23
documentation
0510147
@bbean23
generify View3d.draw_xyz_surface()
0e6619e
@bbean23
add 'gradient' option to View3d.draw_pq_list()
0a2dd20
@bbean23
typo
a8b69a3
@bbean23
standardize "color" import as "cl"
486e5f4
@bbean23
move color.py -> Color.py
59b3e6d
@bbean23
finish moving color.py -> Color.py
b377fa9
@bbean23
update RenderControlSurface to internally represent self.color as a C…
7973e5d 
…olor object
@bbean23
fix another reference to "color" instead of "Color"
c799c24
@bbean23
I'm 100% sure I already fixed this >.<
616d4d7
@bbean23
move test_color -> test_Color part 1
5e2ae7e
@bbean23
move test_color -> test_Color part 2
4f44ed4
@bbean23
forgot the reference image for the test
4c290d0
@bbean23 bbean23 force-pushed the 148-even-more-drawing-options branch from b94100e to 4c290d0 Compare September 6, 2024 16:53
@bbean23 bbean23 merged commit 772ecae into sandialabs:develop Sep 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braden6521 braden6521 braden6521 approved these changes

@e10harvey e10harvey Awaiting requested review from e10harvey

Assignees

@bbean23 bbean23

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbean23 @braden6521