Visualize slope map #118
Merged
Visualize slope map #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
braden6521
commented
Jun 12, 2024
braden6521
commented
- Added ability to get orthorectified slope array from mirror objects as numpy array, not just as plot. This is useful when performing unique analyses on an optic and not just plotting the slope image.
- Pulled out generic functions into separate library (visualize_orthorectified_image.py). This is needed when you are creating unique plots not natively part of OpenCSP, but want to have the same format as OpenCSP.
- Added unit tests.
e10harvey
previously approved these changes
Jun 18, 2024
braden6521
force-pushed
the
visualize_slope_map
branch
from
f19d330
to
a5a872d
Compare
|
@e10harvey. Rebased on develop. Could you please review again? |
braden6521
force-pushed
the
visualize_slope_map
branch
from
a5a872d
to
fc62a89
Compare
e10harvey
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Thank you, @braden6521. In the future, consider strengthening the tests by generating random input sizes, e.g.:
shape = RegionXY.from_vertices(Vxy(([rand_float modulo upper_bound, ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.