Fixed filterExtended() issue, not calculating mask correctly #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dirkandterra thanks for the submitting the fix, I don't have the hardware to test at the moment. If someone can test and add a comment that this works, I'll proceed with merging. |
|
Not sure if you need someone else to verify, but I did test this as working with a ESP32
On Sunday, March 31, 2024 at 08:59:13 AM CDT, Sandeep Mistry ***@***.***> wrote:
@dirkandterra thanks for the submitting the fix, I don't have the hardware to test at the moment.
If someone can test and add a comment that this works, I'll proceed with merging.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extended mask calculation had an error in it.