Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add language processing to ldpath service #284

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elrayle
Copy link
Contributor

@elrayle elrayle commented Nov 11, 2019

[WIP] Pending change in ldpath gem


Fixes #288; Partially addresses #289

The ldpath_service was not honoring requests for languages. With this change, if languages are passed into the ldpath_program method and the property being requested has a language marker in it, the program will create a request for each language and for all untagged literals.

The ldpath_execute method will recombine these values into language tagged RDF::Literals.

Without this, the language processing in QA is unable to properly sort multiple values within a single language.

@elrayle elrayle changed the title add language processing to ldpath service [WIP] add language processing to ldpath service Nov 20, 2019
@elrayle elrayle force-pushed the ldpath_languages branch 2 times, most recently from 830b75f to b6da716 Compare November 21, 2019 00:34
@elrayle elrayle mentioned this pull request Nov 21, 2019
5 tasks
NOTE: This commit references a branch in ldpath.  It needs to be removed when PR #18 is merged into the ldpath gem.
@jrgriffiniii
Copy link
Contributor

Apologies for any annoyance, but this is to please document and confirm that samvera-labs/ldpath#18 is actually a blocking PR for merging these proposed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

primary label fails to sort when specified using ldpath
2 participants