Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send string ids into job #6975

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Send string ids into job #6975

merged 2 commits into from
Nov 15, 2024

Conversation

laritakr
Copy link
Contributor

@laritakr laritakr commented Nov 15, 2024

Fix bugs:

Serialize was failing on valkyrie ids
@laritakr laritakr added the notes-bugfix Release Notes: Fixed a bug label Nov 15, 2024
Copy link

github-actions bot commented Nov 15, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 17m 18s ⏱️ + 1m 23s
 6 733 tests ±0   6 437 ✅ ±0  296 💤 ±0  0 ❌ ±0 
13 240 runs  ±0  12 841 ✅ ±0  399 💤 ±0  0 ❌ ±0 

Results for commit e56340c. ± Comparison against base commit a9c8e9c.

This pull request removes 274 and adds 274 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f6dc88f9b10>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fbc3643a298>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f6dc61a3ac0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fbc35327460>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 202a11b8-8da5-4ed8-89f1-9adc7c45640d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 41f82223-3ec4-4e60-9ca6-36d5b83d23c9
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 3cb48cde-400f-415b-804c-c597394798ac
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: efa49605-5683-442e-afc0-51050fd61bdb
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 7f7eb45d-4a4d-4355-986e-8b0ff3bf6f45
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: ee127e5c-a3aa-46c8-add5-a89a508320e0
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f133179e398>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc27adf44d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f1331665648>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc296b65020>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: ae3327de-628b-4648-91c2-bbdb33b678f4
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 510fa018-05c0-4d82-b249-669f9bb96d76
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: e9a56ebe-d301-4e93-92da-7e45d6609319
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 936b2b45-a36b-4751-8e77-d9c09a19d919
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 5ccad857-9103-4cd8-924c-f873f7cbab63
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 78cf5565-31ae-439d-a1de-0a293cb35f5d
…

♻️ This comment has been updated with latest results.

@laritakr laritakr marked this pull request as ready for review November 15, 2024 19:12
@orangewolf orangewolf merged commit abd5955 into main Nov 15, 2024
22 checks passed
@orangewolf orangewolf deleted the send-string-ids-to-job branch November 15, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants