Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TimeService when determining expired embargoes/leases #6972

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

dlpierce
Copy link
Contributor

@dlpierce dlpierce commented Nov 8, 2024

This allows timely local testing of embargoes/leases without waiting a day for the expiration, or resorting to other temporal shenanigans.

Changes proposed in this pull request:

  • Use a time generated from Hyrax::TimeService (which might be altered for testing purposes) instead of solr's internal time.

@samvera/hyrax-code-reviewers

This allows timely local testing without waiting a day for the expiration.
@dlpierce dlpierce added the notes-minor Release Notes: Non-breaking features label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 17m 52s ⏱️ + 2m 58s
 6 729 tests ±0   6 432 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 229 runs  ±0  12 833 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit 454c42a. ± Comparison against base commit ae082d1.

This pull request removes 273 and adds 273 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f94907c2320>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fdb77a4f290>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f948fda2f98>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fdb77a78e88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 7105a0b0-689c-436b-9ecb-0c30561dec8c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 36e0da11-de11-4ad0-8e88-36a2a4d4f04d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 6ad54a1c-c4f7-4ccd-83fc-4ab7a1548d48
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 39b7eb86-477b-4493-a870-6bf9630a27e0
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 70d66051-64e0-49aa-a9e1-dca1ce53f97d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 1a0c9f7c-d92b-4fea-9679-8b290053d872
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007effadd9a018>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f370b90e4c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007effaddd8200>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f370b89e380>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: a76ce8b1-fc46-4054-aa75-63974eb490ac
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 48c2340d-d2df-4819-be6f-ccfa2297f496
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: be1ccb40-58b0-4a53-9aea-05bd425b1cfc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: cfe1e4dd-b0c6-4185-9975-3333aeb4be0c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 0914c63d-1c86-4197-bfa4-6699b5c27895
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 62f738b8-1921-4d29-b29b-98843b8cc6d0
…

♻️ This comment has been updated with latest results.

@orangewolf orangewolf merged commit d60db08 into main Nov 11, 2024
22 checks passed
@orangewolf orangewolf deleted the embargo-lease-time-service branch November 11, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-minor Release Notes: Non-breaking features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants