🐛 Fix importers sorting for last run and next run #977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🐛 Fix importers sorting for last run and next run
7d985dd
This commit will fix the sorting error that happens when the user is on
the importers index and attempts to sort by the last run or next run. We
add some migrations to add fields that the datatables can use so it can
sort properly. Previously, this was not working because the
last_imported_at and next_import_at fields were actually methods on the
importer_run object and not the importer object. We are adding a few
callbacks to the importer and importer_run models to ensure that the
fields are properly set when they are called from either the web or the
worker.
Ref:
Zight.Recording.2024-09-16.at.16.43.37.mp4
🤖 Update upload-artifact and download-artifact
aca33e5
CI was getting errors because the versions we were previously using were
deprecated. This commit updates the actions to the latest versions.
🐛 Remove Downloadable Files sorting
d4d4749
The downloadable files sorting was broken plus, it's not clear now a
downloadable file should be sorted.
⚙️ Add guard for new migrations
7011d72
This commit will add a guard to the new migrations to ensure that they
do not run if the columns already exist in the database.
Note
To get the changes all the Importers need to be updated, something like: