Skip to content

1.6.3
Compare
Choose a tag to compare
@mjgiarlo mjgiarlo released this 21 Oct 15:50
· 324 commits to master since this release
v1.6.3
90eb6a7 
This updates to the new syntax in Turbolinks 5.

Unfortunately, the old syntax is no longer supported so dual support for
older and current Rails is not an option here. More fortunately,
`target="_blank"` should serve as a fallback anyway.     
The show actions for file sets did not include a `"_blank"` target for
the download link. The other download links uniformly open in a new
browser tab, so this makes the behavior consistent.
"_new" is not a browsing context keyword in HTML. Some browsers seem to
implement it, but the spec recommends they ignore it.

Turbolinks causes xhr requests on local links. For file downloads, this
causes browsers to render the contents as text, instead of playing media
or displaying the PDF in a viewer.

Changes

  • Update data-no-turbolink to data-turbolinks="false" [Tom Johnson]
  • Add _blank target to "Download this File" link [Tom Johnson]
  • Replace href target "_new" with "_blank" [Tom Johnson]
  • Disable turbolinks on file download links [Tom Johnson]
Assets 2
Loading