Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating package verison and required Django version #85

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

calyth
Copy link

@calyth calyth commented Jul 13, 2016

6d864e1 fixed a Django 1.9 incompatibility.
Bumping the package version, and required django version

6d864e1 fixed a Django 1.9 incompatibility.
Bumping the package version, and required django version
@samuraisam
Copy link
Owner

Hmm. I don't think this is actually what we want, because the django-json-rpc package is actually compatible with older versions of Django.

@calyth
Copy link
Author

calyth commented Jul 13, 2016

Hmm. So I played around a bit, and the json browser didn't complain about
the missing -{% load url from future %} when I used Django 1.8.13.

Would it be sufficient to drop the django version restriction (i.e. revert
back to Django>=1.0), and publish a new version of this package without the
load url from future in the template?

On Tue, Jul 12, 2016 at 9:12 PM Samuel Sutch [email protected]
wrote:

Hmm. I don't think this is actually what we want, because the
django-json-rpc package is actually compatible with older versions of
Django.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#85 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AC2egmEwiccbsCeryhCjAV7k0utk-4pPks5qVDt4gaJpZM4JK-Ui
.

@samuraisam
Copy link
Owner

samuraisam commented Jul 13, 2016

Probably, and to be honest, I don't think many people are using the JSON-RPC "explorer" which was a feature I added for a client a long time ago, and have considered removing ever since. I'd be happy with removing that entire thing, and if people wanted it, could either pin to an older version of django-json-rpc, or could pull it into their project.

@calyth
Copy link
Author

calyth commented Jul 19, 2016

I find the browser could be useful as a means of discovering what's there. It's not super critical, but might be nice if people could pick up the change from PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants