Cleaned up client actions [SLE-194]

src/Application/Actions/Client/Ajax/ApiClientCreateAction.php

@@ -3,7 +3,6 @@
 namespace App\Application\Actions\Client\Ajax;
 
 use App\Application\Responder\Responder;
-use App\Application\Validation\MalformedRequestBodyChecker;
 use App\Domain\Client\Service\ClientCreatorFromClientSubmit;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
@@ -13,17 +12,9 @@
  */
 final class ApiClientCreateAction
 {
-    /**
-     * The constructor.
-     *
-     * @param Responder $responder The responder
-     * @param ClientCreatorFromClientSubmit $clientCreatorFromClientSubmit
-     * @param MalformedRequestBodyChecker $malformedRequestBodyChecker
-     */
     public function __construct(
         private readonly Responder $responder,
         private readonly ClientCreatorFromClientSubmit $clientCreatorFromClientSubmit,
-        private readonly MalformedRequestBodyChecker $malformedRequestBodyChecker,
     ) {
     }
 

src/Application/Actions/Client/Ajax/ClientCreateAction.php

@@ -7,17 +7,8 @@
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 
-/**
- * Action.
- */
 final class ClientCreateAction
 {
-    /**
-     * The constructor.
-     *
-     * @param Responder $responder The responder
-     * @param ClientCreator $clientCreator
-     */
     public function __construct(
         private readonly Responder $responder,
         private readonly ClientCreator $clientCreator,

src/Application/Actions/Client/Ajax/ClientDeleteAction.php

@@ -12,21 +12,10 @@
 use Psr\Http\Message\ServerRequestInterface;
 use Psr\Log\LoggerInterface;
 
-/**
- * Action.
- */
 final class ClientDeleteAction
 {
     protected LoggerInterface $logger;
 
-    /**
-     * The constructor.
-     *
-     * @param Responder $responder The responder
-     * @param ClientDeleter $clientDeleter
-     * @param SessionInterface $session
-     * @param LoggerFactory $logger
-     */
     public function __construct(
         private readonly Responder $responder,
         private readonly ClientDeleter $clientDeleter,
@@ -43,8 +32,6 @@ public function __construct(
      * @param ResponseInterface $response The response
      * @param array $args
      *
-     * @throws \JsonException
-     *
      * @return ResponseInterface The response
      */
     public function __invoke(

src/Application/Actions/Client/Ajax/ClientFetchListAction.php

@@ -3,21 +3,15 @@
 namespace App\Application\Actions\Client\Ajax;
 
 use App\Application\Responder\Responder;
-use App\Domain\Authorization\UnauthorizedException;
 use App\Domain\Client\Exception\InvalidClientFilterException;
 use App\Domain\Client\Service\ClientFinderWithFilter;
+use App\Test\Integration\Client\ClientListActionTest;
 use Fig\Http\Message\StatusCodeInterface;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 
 final class ClientFetchListAction
 {
-    /**
-     * The constructor.
-     *
-     * @param Responder $responder The responder
-     * @param ClientFinderWithFilter $clientFilterFinder
-     */
     public function __construct(
         private readonly Responder $responder,
         private readonly ClientFinderWithFilter $clientFilterFinder,
@@ -31,8 +25,6 @@ public function __construct(
      * @param ResponseInterface $response The response
      * @param array $args
      *
-     * @throws \JsonException
-     *
      * @return ResponseInterface The response
      */
     public function __invoke(
@@ -48,27 +40,13 @@ public function __invoke(
         } catch (InvalidClientFilterException $invalidClientFilterException) {
             return $this->responder->respondWithJson(
                 $response,
-                // Response format tested in PostFilterProvider.php
+                /** @see ClientListActionTest::testClientListActionInvalidFilters() */
                 [
                     'status' => 'error',
                     'message' => $invalidClientFilterException->getMessage(),
                 ],
                 StatusCodeInterface::STATUS_UNPROCESSABLE_ENTITY
             );
-        } // If user requests its own posts he has to be logged in
-        catch (UnauthorizedException $unauthorizedException) {
-            // Respond with status code 401 Unauthorized which is caught in the Ajax call
-            return $this->responder->respondWithJson(
-                $response,
-                [
-                    'loginUrl' => $this->responder->urlFor(
-                        'login-page',
-                        [],
-                        ['redirect' => $this->responder->urlFor('client-list-assigned-to-me-page')]
-                    ),
-                ],
-                401
-            );
         }
     }
 }

src/Application/Actions/Client/Ajax/ClientUpdateAction.php

@@ -4,24 +4,15 @@
 
 use App\Application\Responder\Responder;
 use App\Domain\Client\Service\ClientUpdater;
-use App\Domain\Factory\LoggerFactory;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
-use Psr\Log\LoggerInterface;
 
-/**
- * Action.
- */
 final class ClientUpdateAction
 {
-    protected LoggerInterface $logger;
-
     public function __construct(
         protected readonly Responder $responder,
         private readonly ClientUpdater $clientUpdater,
-        LoggerFactory $logger,
     ) {
-        $this->logger = $logger->addFileHandler('error.log')->createLogger('client-update');
     }
 
     /**
@@ -32,7 +23,6 @@ public function __construct(
      * @param array $args
      *
      * @return ResponseInterface The response
-     *
      */
     public function __invoke(
         ServerRequestInterface $request,

src/Application/Actions/Client/Ajax/FetchDropdownOptionsForClientCreateAction.php

@@ -11,12 +11,6 @@
 
 class FetchDropdownOptionsForClientCreateAction
 {
-    /**
-     * The constructor.
-     *
-     * @param Responder $responder The responder
-     * @param ClientUtilFinder $clientUtilFinder
-     */
     public function __construct(
         private readonly Responder $responder,
         private readonly ClientUtilFinder $clientUtilFinder,
@@ -30,8 +24,6 @@ public function __construct(
      * @param ResponseInterface $response The response
      * @param array $args
      *
-     * @throws \JsonException
-     *
      * @return ResponseInterface The response
      */
     public function __invoke(

src/Application/Actions/Client/Page/ClientListPageAction.php

@@ -9,18 +9,8 @@
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 
-/**
- * Action.
- */
 final class ClientListPageAction
 {
-    /**
-     * The constructor.
-     *
-     * @param Responder $responder The responder
-     * @param ClientListFilterChipProvider $clientListFilterChipGetter
-     * @param ClientAuthorizationChecker $clientAuthorizationChecker
-     */
     public function __construct(
         private readonly Responder $responder,
         private readonly ClientListFilterChipProvider $clientListFilterChipGetter,
@@ -35,7 +25,6 @@ public function __construct(
      * @param ResponseInterface $response The response
      * @param array $args
      *
-     * @throws \JsonException
      * @throws \Throwable
      *
      * @return ResponseInterface The response

src/Application/Actions/Client/Page/ClientReadPageAction.php

@@ -8,18 +8,8 @@
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 
-/**
- * Action.
- */
 final class ClientReadPageAction
 {
-    /**
-     * The constructor.
-     *
-     * @param Responder $responder The responder
-     * @param ClientFinder $clientFinder
-     * @param ClientUtilFinder $clientUtilFinder
-     */
     public function __construct(
         private readonly Responder $responder,
         private readonly ClientFinder $clientFinder,

src/Application/Actions/Note/Ajax/NoteCreateAction.php

@@ -9,7 +9,6 @@
 
 final class NoteCreateAction
 {
-
     public function __construct(
         private readonly Responder $responder,
         private readonly NoteCreator $noteCreator,

src/Application/Actions/Note/Ajax/NoteFetchListAction.php

@@ -9,32 +9,21 @@
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 
-/**
- * List notes linked to user action.
- */
 final class NoteFetchListAction
 {
-    /**
-     * The constructor.
-     *
-     * @param Responder $responder The responder
-     * @param NoteFilterFinder $noteFilterFinder
-     */
     public function __construct(
         private readonly Responder $responder,
         private readonly NoteFilterFinder $noteFilterFinder,
     ) {
     }
 
     /**
-     * Note list all and own Action.
+     * Fetch note list with given params action.
      *
      * @param ServerRequestInterface $request The request
      * @param ResponseInterface $response The response
      * @param array $args
      *
-     * @throws \JsonException
-     *
      * @return ResponseInterface The response
      */
     public function __invoke(

src/Application/Actions/Note/Ajax/NoteUpdateAction.php

@@ -3,20 +3,16 @@
 namespace App\Application\Actions\Note\Ajax;
 
 use App\Application\Responder\Responder;
-use App\Domain\Factory\LoggerFactory;
 use App\Domain\Note\Service\NoteUpdater;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 
 final class NoteUpdateAction
 {
-
     public function __construct(
         private readonly Responder $responder,
         private readonly NoteUpdater $noteUpdater,
-        LoggerFactory $logger,
     ) {
-        $this->logger = $logger->addFileHandler('error.log')->createLogger('note-update');
     }
 
     /**

src/Application/Actions/Note/Page/NoteReadPageAction.php

@@ -8,18 +8,8 @@
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 
-/**
- * Action.
- */
 final class NoteReadPageAction
 {
-    /**
-     * The constructor.
-     *
-     * @param Responder $responder The responder
-     * @param NoteFinder $noteFinder
-     * @param SessionInterface $session
-     */
     public function __construct(
         private readonly Responder $responder,
         private readonly NoteFinder $noteFinder,

src/Application/Middleware/ForbiddenExceptionMiddleware.php

@@ -12,7 +12,6 @@
 
 class ForbiddenExceptionMiddleware implements MiddlewareInterface
 {
-
     public function __construct(
         private readonly Responder $responder,
     ) {
@@ -36,4 +35,4 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
             );
         }
     }
-}
+}