Code cleanup [SLE-192]

samuelgfeller · May 7, 2024 · 4927563 · 4927563
1 parent 517d2b0
commit 4927563
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 19 deletions.
diff --git a/src/Domain/Home/PhpDevTester.php b/src/Domain/Home/PhpDevTester.php
diff --git a/src/Domain/Security/Service/SecurityLoginChecker.php b/src/Domain/Security/Service/SecurityLoginChecker.php
@@ -150,17 +150,17 @@ private function performLoginCheck(array $loginsByIp, array $loginsByEmail, stri
      */
     private function performGlobalLoginCheck(): void
     {
-        // Making sure that values returned from repository are cast into integers
+        // Making sure that values returned from the repository are cast into integers
         $loginAmountSummary = array_map('intval', $this->loginRequestFinderRepository->getGlobalLoginAmountSummary());
 
         // Calc allowed failure amount which is the given login_failure_percentage of the total login
         $failureThreshold = floor(
             $loginAmountSummary['total_amount'] / 100 * $this->securitySettings['login_failure_percentage']
         );
-        // Actual failure amount have to be LESS than allowed failures amount (tested this way)
+        // Actual failure amount have to be LESS than allowed failures amount (tested this way).
         // If there are not enough requests to be representative, the failureThreshold is increased to 20 meaning
-        // at least 20 failed login attempts are allowed no matter the percentage
-        // If percentage is 10, throttle begins at 200 login requests
+        // at least 20 failed login attempts are allowed no matter the percentage.
+        // If percentage is 10, throttle begins at 200 login requests.
         if (!($loginAmountSummary['failures'] < $failureThreshold) && $failureThreshold > 20) {
             // If changed, update SecurityServiceTest password spraying test expected error message
             $msg = 'Maximum amount of tolerated unrestricted login requests reached site-wide.';

diff --git a/src/Domain/User/Data/UserActivityData.php b/src/Domain/User/Data/UserActivityData.php
@@ -16,7 +16,7 @@ class UserActivityData
     public ?string $ipAddress;
     public ?string $userAgent;
 
-    // When returning the report to the client add the page url
+    // When returning the report to the frontend add the page url
     public ?string $pageUrl = null;
     public ?string $timeAndActionName = null; // Time in the correct format and action name with upper case
 

diff --git a/src/Domain/User/Enum/UserStatus.php b/src/Domain/User/Enum/UserStatus.php
@@ -5,7 +5,7 @@
 use App\Common\Trait\EnumToArray;
 
 /**
- * User authentication status.
+ * User status.
  */
 enum UserStatus: string
 {