be more forgiving if follow_symlinks=False is not supported #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samschott
force-pushed
the
forgiving-follow-symlinks
branch
from
5012f90
to
9875652
Compare
lstat calls fall back to stat if follow_symlinks=False is not supported
...if follow_symlinks is not supported
samschott
force-pushed
the
forgiving-follow-symlinks
branch
from
9875652
to
cda066f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
follow_symlinks=Falseis not supported for a file system call on the platform, either fall back tofollow_symlinks=True, or skip the call if ok. In particular:stat: Use Python'sos.lstat, which always falls back toos.stat. See https://docs.python.org/3/library/os.html#os.lstat.chmod: Don't call at all iffollow_symlinks=Falseis not supported.open: Don't pass O_NOFOLLOW is not available.Fixes #890.