readme: some updates to the README #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlogistonjohn
requested changes
Dec 9, 2024
README.md
Outdated
| * Are [OCI](https://opencontainers.org/) formatted container images | ||
| * Provide application-like high-level entrypoint scripts | ||
| * Are [OCI](https://opencontainers.org/) formatted container images. | ||
| * Provide application-like high-level entrypoint scripts. |
There was a problem hiding this comment.
These bullet points are sentence fragments. They do not need punctuation. Adding punctuation to only some items and not all of them makes the content inconsistent. Please remove the periods that this PR is adding
obnoxxx
force-pushed
the
readme-update
branch
from
09c83a3 to
fe10e3b
Compare
mergify
bot
dismissed
synarete’s stale review
Pull request has been modified.
phlogistonjohn
requested changes
Dec 16, 2024
README.md
Outdated
| @@ -9,6 +9,7 @@ Container images for [Samba](https://samba.org) services. | |||
| * Are used by the [samba-operator](https://github.com/samba-in-kubernetes/samba-operator) for Kubernetes | |||
| * Don't require Kubernetes | |||
| * Are [available at quay.io](https://quay.io/organization/samba.org) | |||
| * Are used by the [ceph project](https://github.com/ceph/ceph) to provide SMB services on CephFS. | |||
There was a problem hiding this comment.
this one still has a trailing period at the end of the line
Signed-off-by: Michael Adam <[email protected]>
obnoxxx
force-pushed
the
readme-update
branch
from
fe10e3b to
cbb0134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve some links and mention that the containers are used by ceph.