remove robot-type restriction and add joints prefix #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichlf
reviewed
Jul 18, 2024
erichlf
approved these changes
Jul 18, 2024
erichlf
approved these changes
Jul 22, 2024
SyZbidi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when launching the
abb_moveit.launch.pythe only supported robot is theirb1200_5_90, remapping to another robot was not allowed due to the restrictions set in the launch file by the parameterchoicesinDeclareLaunchArgument.The joints names in the controller's yaml file were missing the prefix we use for the robot so I renamed them accordingly
Removed the parameter to allow setting the robot type and files without limitations