Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for scalar as alternative for swagger ui #458

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Add support for scalar as alternative for swagger ui #458

merged 2 commits into from
Oct 18, 2023

Conversation

chrislearn
Copy link
Member

@chrislearn chrislearn commented Oct 18, 2023 •
edited
Loading

@prabirshrestha
Copy link
Contributor

Awesome. Thanks for adding this. Curious what it would take to share the files withing the crate so there is are no dependencies with the public internet. This could be solved later with the following api.

Scalar::new("/api-doc/openapi.json").with_script_path("/public/@scalar/api-reference")

@chrislearn chrislearn merged commit b5d5b87 into salvo-rs:main Oct 18, 2023
@chrislearn
Copy link
Member Author

Awesome. Thanks for adding this. Curious what it would take to share the files withing the crate so there is are no dependencies with the public internet. This could be solved later with the following api.

Scalar::new("/api-doc/openapi.json").with_script_path("/public/@scalar/api-reference")

Done: #461

@prabirshrestha
Copy link
Contributor

Thanks!

@chrislearn chrislearn deleted the scalar branch November 23, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrislearn @prabirshrestha