Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl ToSchema for Ipv4Addr, Ipv6Addr, IpAddr #1014

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

Samyak2
Copy link
Contributor

@Samyak2 Samyak2 commented Dec 29, 2024

  • I noticed that ToSchema was missing for these types from std::net.
  • This was needed for the Shuttlings Christmas Code Hunt 2024 (challenge 2).
  • I'm not sure about the implementation for IpAddr enum. Let me know how it can be improved.

- I noticed that ToSchema was missing for these types from std::net
- This was needed for the Shuttlings Christmas Code Hunt 2024 (challenge 2)
@chrislearn chrislearn merged commit 0478860 into salvo-rs:main Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants