Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kwargs request #11

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Kwargs request #11

merged 1 commit into from
Sep 6, 2024

Conversation

Moosems
Copy link
Member

@Moosems Moosems commented Sep 6, 2024

Fixes #10.

To do:

  • Use keyword arguments instead of a dict for requests

Current changes in PR:

  • Update Client/Server
  • Update FileClient/FileServer
  • Update docs
  • Update examples
  • Update tests

@Moosems Moosems added the enhancement New feature or request label Sep 6, 2024
@Moosems Moosems added this to the v0.3.0 milestone Sep 6, 2024
@Moosems Moosems self-assigned this Sep 6, 2024
@Moosems Moosems changed the base branch from master to v0.3.0 September 6, 2024 21:52
@Moosems Moosems merged commit a252db8 into v0.3.0 Sep 6, 2024
6 checks passed
@Moosems Moosems deleted the kwargs_request branch September 6, 2024 21:53
Moosems added a commit that referenced this pull request Sep 7, 2024
* Remove unused line

* Better sorting, better type usage

* Remove print and update init

* Format

* isort

* Update simple_example.py

* Update string

* Multiple runs single command (#8)

* Current progress

* Fill in Server

* Get some requests going!

* Remove logging, fix add command

* Finish major legwork

* Start formalizing the changes

* Get tests running

* Update setup.py

* Typo

* Update examples and tests

* Return differently based on command

* Formatting

* Update docs

* Use keyword args instead of a dict (#11)

* Prepare Release Candidate 0

* Fix pyright issues and docstrings

* Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Idea: Use kwargs instead of a request_details dict
1 participant