Fix bugs and improve tests marginally

salve-org · Jul 29, 2024 · 1ae4972 · 1ae4972
1 parent 66461cf
commit 1ae4972
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/collegamento/files_variant.py b/collegamento/files_variant.py
@@ -54,9 +54,7 @@ def update_file(self, file: str, current_state: str) -> None:
         self.files[file] = current_state
 
         self.logger.debug("Creating notification dict")
-        notification: FileNotification = {
-            "id": super().create_message_id(),
-            "type": "notification",
+        notification: FileNotification = {  # type: ignore
             "file": file,
             "remove": False,
             "contents": self.files[file],

diff --git a/collegamento/simple_client_server/client.py b/collegamento/simple_client_server/client.py
@@ -96,7 +96,6 @@ def notify_server(
         }
         final_notification.update(notification_dict)
         self.logger.debug(f"Notification created: {final_notification}")
-
         self.requests_queue.put(final_notification)
         self.logger.info("Message sent")
 

diff --git a/tests/test_file_variant.py b/tests/test_file_variant.py
@@ -34,6 +34,8 @@ def test_file_variants():
     assert output is not None  # noqa: E711
     assert output["result"] == ["test", "contents"]  # noqa: E712 # type: ignore
 
+    assert context.all_ids == []
+
     context.kill_IPC()
 
 

diff --git a/tests/test_simple.py b/tests/test_simple.py
@@ -34,4 +34,6 @@ def test_Client_Server():
     assert output is not None  # noqa: E711
     assert output["result"] == False  # noqa: E712 # type: ignore
 
+    assert context.all_ids == []
+
     context.kill_IPC()