Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3007.x] Add MAINTAIN (m) privilege to postgres module lookup tables #66964

Open
wants to merge 6 commits into
base: 3007.x
Choose a base branch
from

Conversation

jdelic
Copy link
Contributor

@jdelic jdelic commented Oct 11, 2024

What does this PR do?

Adds MAINTAIN (m) to the supported privileges in salt.modules.postgres.

What issues does this PR fix or reference?

Fixes #66962

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@jdelic jdelic requested a review from a team as a code owner October 11, 2024 20:45
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fix/postgres maintain privilege [3007.x] Fix/postgres maintain privilege Oct 11, 2024
@jdelic jdelic changed the title [3007.x] Fix/postgres maintain privilege [3007.x] Add MAINTAIN (m) privilege to postgres module lookup tables Oct 11, 2024
Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind writing a test for this?

@elpavel
Copy link

elpavel commented Oct 28, 2024

Is there a way to test this @twangboy ? The current test suite doesn't run tests against a Postgres database (if I remember well).

I did implement the same change as in this patch in our salt, to allow privileges management on our Postgres 17 databases. Thanks @jdelic it works OK.

@twangboy
Copy link
Contributor

Looks like there's a test failure.

@jdelic jdelic force-pushed the fix/postgres-maintain-privilege branch from b1aa982 to 613e760 Compare October 31, 2024 21:41
@jdelic
Copy link
Contributor Author

jdelic commented Nov 1, 2024

@twangboy thank you for the approval. I don't think the CI has run my modified tests yet... Any idea how to get them to run? It looks to me like a failure on the test infrastructure 🤷‍♂️

@twangboy
Copy link
Contributor

twangboy commented Nov 6, 2024

With the recent changes to our internal infrastructure mandated echelons above us with minimal notice, most of our pipeline is broken. Once it is fixed you can rebase and the tests should run.

@jdelic
Copy link
Contributor Author

jdelic commented Nov 6, 2024

@twangboy yeah, I realized that the pipelines don't yet point to the Broadcom endpoints. 😁

I'll wait for the 3007.x branch to be fixed and proceed accordingly. Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants