-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3007.x] Add MAINTAIN (m) privilege to postgres module lookup tables #66964
base: 3007.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind writing a test for this?
Looks like there's a test failure. |
b1aa982
to
613e760
Compare
@twangboy thank you for the approval. I don't think the CI has run my modified tests yet... Any idea how to get them to run? It looks to me like a failure on the test infrastructure 🤷♂️ |
With the recent changes to our internal infrastructure mandated echelons above us with minimal notice, most of our pipeline is broken. Once it is fixed you can rebase and the tests should run. |
@twangboy yeah, I realized that the pipelines don't yet point to the Broadcom endpoints. 😁 I'll wait for the 3007.x branch to be fixed and proceed accordingly. Thank you 🙏 |
What does this PR do?
Adds
MAINTAIN
(m) to the supported privileges in salt.modules.postgres.What issues does this PR fix or reference?
Fixes #66962
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes