Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guzzle sender that extends Saloon's default sender (linked to PR in saloon itself) #62

Closed
wants to merge 1 commit into from

Conversation

gdebrauwer
Copy link

@gdebrauwer gdebrauwer commented Apr 18, 2024

I noticed the laravel-http-sender package is being sunset, but I still want requests/responses to be logged in Telescope. Then I discovered this is possible with the following package: https://github.com/huzaifaarain/telescope-guzzle-watcher/tree/main

The problem is that this package only works if the guzzle client is created using the service container. That is currently not the case.

This PR and PR saloonphp/saloon#403 make that possible with minimal changes.

Copy link
Member

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gdebrauwer I like this addition, I'm a little worried this might start causing issues for people. Do you forsee any issues with introducing this in the next minor update, like issues with closing connections with Octane? etc.

@gdebrauwer
Copy link
Author

I don't think this will cause issues on Octane as we are not creating a singleton.
I can't think of any issues that could occur because of this change.

@pajkho
Copy link

pajkho commented Jul 11, 2024

Whats the status on this? @Sammyjo20

@Sammyjo20 Sammyjo20 closed this Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants