Use symfony/finder
to find Requests within Subdirectories
#58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53
This PR fixes the issue raised in the Issue above, in that when running
php artisan saloon:list
, if your files live in a subdirectory, then it doesn't find them and actually fails:It didn't even occur to me that some applications would do this 😆
Fortunately,
symfony/finder
comes to the rescue and makes it easy to find files in directories. This PR basically just swaps usages ofglob()
to instead usesymfony/finder
. With this branch, if you runphp artisan saloon:list
, you now get the expected output:Notice how my Requests live in subdirectories?
This PR actually makes a couple more changes:
StripeConnector.php
. If I was to just name itStripe.php
, then that would also work