Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | V3 - Deprecated MockClient, use Global Mock Client #55

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

Sammyjo20
Copy link
Member

This PR makes a few changes

  • Deprecated the Saloon facade
  • Deprecated the MockClient class if people were using it
  • Uses the new Global Mock Client internally for mocking
  • Automatically destroys the global mock client in the service provider
  • Fixes PHPStan issues
  • Installs PHPStan workflow file
  • Introduces PHP 8.3 for testing

Copy link
Member Author

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

@Sammyjo20 Sammyjo20 merged commit 2997b5d into v3 Jan 21, 2024
14 checks passed
@Sammyjo20 Sammyjo20 deleted the feature/deprecate-old-saloon-fake branch February 12, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant