Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11 #54

Closed
wants to merge 0 commits into from
Closed

Laravel 11 #54

wants to merge 0 commits into from

Conversation

SamuelMwangiW
Copy link
Contributor

@SamuelMwangiW SamuelMwangiW commented Jan 16, 2024

This is a draft PR to add support for the upcoming Laravel major version.


Why Sqlite?

Interestingly, the Windows builds with Laravel 11 & Workbench 9 fails with driver error if sqlite and sqlite_pdo extensions are not enabled.

image

I am not sure if this will go away once workbench and Laravel 11 are stable

Why saloonphp/saloon 3.0.1?

Due to the lower minimum stability, prefer-lowest was therefore resolving to v3.0.0-beta.1 which did not have the Saloon\Config class.

This change should have been part of 79b6463 and may be reverted once Laravel 11 is stable.

This is no longer relevant


I was not sure if this should target v3 branch.

Thanks Sam for your incredible work on this project

SamuelMwangiW added a commit to SamuelMwangiW/africastalking-laravel that referenced this pull request Jan 16, 2024
@serwin35
Copy link

When are you going to add support to 11?

@Sammyjo20
Copy link
Member

@serwin35 When it is out :)

@serwin35
Copy link

@serwin35Kiedy wyjdzie :)

well don't be like that :D it would be useful for me to start putting all the finishing touches on 11 already ;D

@Sammyjo20
Copy link
Member

Sammyjo20 commented Jan 24, 2024

I will release this PR the same day Laravel 11 will release - if I were to release this PR early I would have to allow for dev versions of dependencies and allow an unreleased version of Laravel which seems dangerous.

@SamuelMwangiW
Copy link
Contributor Author

Thanks team for the interest in this PR.

if I were to release this PR early I would have to allow for dev versions of dependencies and allow an unreleased version of Laravel which seems dangerous.

This is the reason the PR is in draft state. I will revert 79b6463 as well this line change before it can be ready to review.

@SamuelMwangiW
Copy link
Contributor Author

@serwin35Kiedy wyjdzie :)

well don't be like that :D it would be useful for me to start putting all the finishing touches on 11 already ;D

Am not sure if it helps but here is how am using this PR to prep my package for 11 SamuelMwangiW/africastalking-laravel@bc876ac

@SamuelMwangiW
Copy link
Contributor Author

-- deleted by mistake 🙈. Will try to reopen or resubmit

@SamuelMwangiW SamuelMwangiW deleted the l11 branch March 7, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants