Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade | Minimum Laravel 10 For Future Releases #52

Merged
merged 2 commits into from
Nov 11, 2023

Conversation

JonPurvis
Copy link
Contributor

Speaking with @Sammyjo20 about this pre V3 being released and it was decided to hold off on this until after that was released, so people can still upgrade to V3, if they're running an older version of Laravel.

Now that V3 has been in the wild for some time, this PR updates the necessary dependencies so that any new versions of this package, will only run on Laravel 10. I've tested this myself on a Laravel 9 application and get the following:

  Problem 1
    - Root composer.json requires saloonphp/laravel-plugin dev-bump-to-laravel-10 -> satisfiable by saloonphp/laravel-plugin[dev-bump-to-laravel-10].
    - saloonphp/laravel-plugin dev-bump-to-laravel-10 requires illuminate/console ^10.0 -> found illuminate/console[v10.0.0, ..., 10.x-dev] but these were not loaded, likely because it conflicts with another require.

and then on Laravel 10:

- Downloading saloonphp/laravel-plugin (dev-bump-to-laravel-10 b28bff3)
- Upgrading saloonphp/laravel-plugin (v3.0.0 => dev-bump-to-laravel-10 b28bff3): Extracting archive
- Generating optimized autoload files

@JonPurvis
Copy link
Contributor Author

@Sammyjo20 as discussed! 🍻

Copy link
Member

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo, nice one @JonPurvis 🔥

@Sammyjo20 Sammyjo20 changed the title bump to laravel 10 Upgrade | Minimum Laravel 10 For Future Relases Nov 11, 2023
@Sammyjo20 Sammyjo20 merged commit 6fb2711 into saloonphp:v3 Nov 11, 2023
9 checks passed
@JonPurvis
Copy link
Contributor Author

Thanks for the speedy approval and merge @Sammyjo20 🥳

This should mean that #50 is ready to go, I think?

@JonPurvis JonPurvis changed the title Upgrade | Minimum Laravel 10 For Future Relases Upgrade | Minimum Laravel 10 For Future Releases Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants