Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to FontAweome 5 (VueJS) #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rootasjey
Copy link
Contributor

EDIT: Hi, sorry, it seems that I had to open an issue first to discuss if this was a wanted improvement. Let me know if the project doesn't have plan to migrate to newer FontAwesome version. Thanks.

This PR update the FontAwesome version to 5.x which add new icons.

I've checked and tested that this update doesn't break any existing resume. Feel free to double check.

The benefits to update to version 5:

  • New icons available, like branded icons
  • Smaller app footprint (because you can choose which icons you want, all icons don't load automatically anymore)
  • Vue friendly syntaxe

I removed the old FontAwesome package.

For the creative and cool resumes, I had to add some properties to auto-create icons:

- name: Drawing
  icon:
    prefix: 'fa'
    name: 'pencil-alt'
  url: https://example.com

But you still have to load the specifics icons in the suitable resume like this:

import { library } from '@fortawesome/fontawesome-svg-core';

import { faGamepad, faGlobeAfrica, faHeart } from '@fortawesome/free-solid-svg-icons';

import { faGithub, faMedium } from '@fortawesome/free-brands-svg-icons';

library.add(faGamepad, faGithub, faGlobeAfrica, faHeart, faMedium);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants