Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ui for tracking #819

Merged
merged 7 commits into from
Nov 28, 2023
Merged

feat: ui for tracking #819

merged 7 commits into from
Nov 28, 2023

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Nov 21, 2023

requires forcedotcom/source-tracking#511

What does this PR do?

  1. subscribe to lifecycle event from STL
  2. use the existing ProgressBar to show when SourceMember polling is happening and what the progress is
  3. hide tests section when there are none
  4. hide errors when there are none

What issues does this PR fix or reference?

@W-14535759@

@mshanemc mshanemc changed the title Sm/UI for tracking feat: ui for tracking Nov 21, 2023
@@ -263,7 +263,7 @@ export default class DeployMetadata extends SfCommand<DeployResultJson> {
}

protected catch(error: Error | SfError): Promise<SfCommand.Error> {
if (error instanceof SourceConflictError) {
if (error instanceof SourceConflictError && error.data) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ : should this check the length of error.data?

It's a required arg:
https://github.com/forcedotcom/source-tracking/pull/511/files#diff-76b31628824755a528610210e965f349b1c66c2a2ac1e880cf02b4d3b1020a17R76

but STL could do throw new SourceConflictError(${conflicts.length} conflicts detected, []) and make this pass.

Copy link
Member

@cristiand391 cristiand391 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with one question.

@cristiand391
Copy link
Member

QA notes:

✅ successful deploy shows tracking progress (complete)

➜  dreamhouse-lwc git:(main) sf project deploy start
 ›   Warning: @salesforce/plugin-deploy-retrieve is a linked ESM module and cannot be auto-transpiled. Existing
 ›   compiled source will be used instead.
Deploying v59.0 metadata to [email protected] using the v59.0 SOAP API.
Deploy ID: 0Af7e00001cyqarCAA
Status: Succeeded | ████████████████████████████████████████ | 91/91 Components | Tracking: 146/146

✅ hidden error count if no errors/ rendered if errors
🟡 tracking count rendered even if there was no tracking update

➜  dreamhouse-lwc git:(main) ✗ sf project deploy start -m CustomObjectTranslation:Broker__c-es
 ›   Warning: @salesforce/plugin-deploy-retrieve is a linked ESM module and cannot be auto-transpiled. Existing compiled source
 ›    will be used instead.
Deploying v59.0 metadata to [email protected] using the v59.0 SOAP API.
Deploy ID: 0Af7e00001cyshXCAQ
Status: Succeeded | ████████████████████████████████████████ | 1/1 Components | Tracking: 0/0

@cristiand391 cristiand391 merged commit a340a5a into main Nov 28, 2023
38 checks passed
@cristiand391 cristiand391 deleted the sm/ui-for-tracking branch November 28, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants