-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ui for tracking #819
Conversation
@@ -263,7 +263,7 @@ export default class DeployMetadata extends SfCommand<DeployResultJson> { | |||
} | |||
|
|||
protected catch(error: Error | SfError): Promise<SfCommand.Error> { | |||
if (error instanceof SourceConflictError) { | |||
if (error instanceof SourceConflictError && error.data) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ : should this check the length of error.data
?
It's a required arg:
https://github.com/forcedotcom/source-tracking/pull/511/files#diff-76b31628824755a528610210e965f349b1c66c2a2ac1e880cf02b4d3b1020a17R76
but STL could do throw new SourceConflictError(
${conflicts.length} conflicts detected, [])
and make this pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with one question.
QA notes: ✅ successful deploy shows tracking progress (complete)
✅ hidden error count if no errors/ rendered if errors
|
What does this PR do?
What issues does this PR fix or reference?
@W-14535759@