Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: message for custom fields wildcard #1052

Merged
merged 5 commits into from
Jun 12, 2024
Merged

docs: message for custom fields wildcard #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2b17def
docs: message for custom fields wildcard
mshanemc Jun 11, 2024
0ec508b
docs: fix message per PR discussion
mshanemc Jun 12, 2024
3a0b409
refactor: use common table header styler
mshanemc Jun 12, 2024
83d7ced
Update retrieve.start.md
jshackell-sfdc Jun 12, 2024
d293688
Merge branch 'sm/custom-field-wildcard-message' of https://github.com…
mshanemc Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion messages/retrieve.start.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ The retrieve target directory [%s] overlaps one of your package directories. Spe

# wantsToRetrieveCustomFields

Because you're retrieving one or more CustomFields, we're also retrieving the CustomObject to which it's associated.
Because you're retrieving one or more CustomFields that you didn't specify the name for, we're also retrieving the CustomObject to which they're associated.

# noSourceTracking

Expand Down
5 changes: 2 additions & 3 deletions src/commands/project/delete/source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,9 @@ import {
requiredOrgFlagWithDeprecations,
SfCommand,
} from '@salesforce/sf-plugins-core';
import ansis from 'ansis';
import { writeConflictTable } from '../../../utils/conflicts.js';
import { isNonDecomposedCustomLabel, isNonDecomposedCustomLabelsOrCustomLabel } from '../../../utils/metadataTypes.js';
import { getFileResponseSuccessProps } from '../../../utils/output.js';
import { getFileResponseSuccessProps, tableHeader } from '../../../utils/output.js';
import { API, DeleteSourceJson, isFileResponseDeleted, isSdrSuccess, isSourceComponent } from '../../../utils/types.js';
import { getPackageDirs, getSourceApiVersion } from '../../../utils/project.js';
import { resolveApi, validateTests } from '../../../utils/deploy.js';
Expand Down Expand Up @@ -187,7 +186,7 @@ export class Source extends SfCommand<DeleteSourceJson> {

if (!this.components.length) {
// if we didn't find any components to delete, let the user know and exit
this.styledHeader(ansis.blue('Deleted Source'));
this.styledHeader(tableHeader('Deleted Source'));
this.log('No results found');
return;
}
Expand Down
4 changes: 2 additions & 2 deletions src/formatters/deleteResultFormatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@
import { Ux } from '@salesforce/sf-plugins-core';
import { DeployResult, FileResponse, FileResponseSuccess, RequestStatus } from '@salesforce/source-deploy-retrieve';
import { ensureArray } from '@salesforce/kit';
import ansis from 'ansis';
import { StandardColors } from '@salesforce/sf-plugins-core';
import { DeleteSourceJson, Formatter, TestLevel, isSdrSuccess } from '../utils/types.js';
import {
exitCodeAsNumber,
fileResponseSortFn,
getFileResponseSuccessProps,
makePathRelative,
tableHeader,
} from '../utils/output.js';
import { TestResultsFormatter } from '../formatters/testResultsFormatter.js';

Expand Down Expand Up @@ -80,7 +80,7 @@ export class DeleteResultFormatter extends TestResultsFormatter implements Forma
}

ux.log('');
ux.styledHeader(ansis.blue('Deleted Source'));
ux.styledHeader(tableHeader('Deleted Source'));
ux.table(
successes.map(getFileResponseSuccessProps),
{
Expand Down
Loading