test(ssr): remove env var, test coverage #5139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Jan 17, 2025
| functions: 95, | ||
| lines: 95, | ||
| statements: 95, | ||
| }, |
There was a problem hiding this comment.
Opened a separate issue to track the low test coverage: #5140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Removes the
TEST_SSR_COMPILERand runs the SSR compiler tests as part of the mainyarn testsuite. Also adds coverage thresholds.The main benefit of this PR is that we now get coverage numbers for the SSR compiler, and plus the test infra is much simpler. The only downside is that there is a somewhat annoying and distracting red "9 failed" message for the mismatched snapshots:
These snapshot failures should ideally be driven down to zero soon. We are reaching the point where many of the differences between
engine-serverandssr-compilerare expected or unimportant. E.g. for HTML global attributes, both systems are wrong (#5123). So it may be time to just deprecateengine-serverand move forward with fixingssr-compiler.Partially addresses #4815.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?