-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hydration): ignore host scope token in class
validation
#4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t has scopd styles and a custom HTML template
nolanlawson
commented
Nov 15, 2024
ekashida
approved these changes
Nov 15, 2024
This was referenced Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #4853
This is only a partial solution to the problem – I have a follow-up for further edge cases: #4866
With this PR, when we render the host scope token (e.g.
class="lwc-abc123-host"
), we also encode it as adata-lwc-host-scope-token
attribute. This tells hydration to ignore certain classes duringclass
validation, which avoids timing issues when using scoped styles andrender()
.To solve this, I'm also simplifying our class validation logic to only look at the differences between two
Set<string>
s. I just don't think it's worth it to care about classes in different orders, or duplicate classes – this doesn't affect CSS styling, and it makes the logic much simpler.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?