Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #373 [SuiteCRM 8]Google API Token for calendar sync in User Profi… #10271

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

abuzarfaris
Copy link
Contributor

@abuzarfaris abuzarfaris commented Nov 30, 2023

…le not working

Open the Google auth window in a new tab

Fixes salesagility/SuiteCRM-Core#373 in SuiteCRM 8

Description

Motivation and Context

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

…n User Profile not working

Open the Google auth window in a new tab
@clemente-raposo clemente-raposo added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Testing Requires Manual Testing Status: Passed Code Review Mark issue has passed code review reviewed labels Dec 14, 2023
Copy link
Contributor

@johnM2401 johnM2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix LGTM

However, this seems to be pointed at the Suite7 Repo as opposed to the SuiteCRM-Core repo.

Should this be ported over to the hotfix branch on SuiteCRM-Core, @clemente-raposo?

If not, this looks good and can be merged.

Thanks!

@johnM2401 johnM2401 added Status:Requires Updates Issues & PRs which requires input or update from the author Status: Passed Testing and removed Status: Requires Testing Requires Manual Testing labels Dec 18, 2023
@abuzarfaris
Copy link
Contributor Author

Fix LGTM

However, this seems to be pointed at the Suite7 Repo as opposed to the SuiteCRM-Core repo.

Should this be ported over to the hotfix branch on SuiteCRM-Core, @clemente-raposo?

If not, this looks good and can be merged.

Thanks!

Hey @johnM2401
I was advised to create this Pull request on the SuiteCRM 7 repo to maintain similar code on both repos
Here is a link to that discussion
salesagility/SuiteCRM-Core#374 (comment)

@johnM2401
Copy link
Contributor

Hey @johnM2401 I was advised to create this Pull request on the SuiteCRM 7 repo to maintain similar code on both repos Here is a link to that discussion salesagility/SuiteCRM-Core#374 (comment)

Ahhhh I see, thank you for clarifying!

In that case, looks good to me, i'll approve for merging now.

Thank you!

@gemartin21 gemartin21 removed the Status:Requires Updates Issues & PRs which requires input or update from the author label Dec 21, 2023
@jack7anderson7 jack7anderson7 merged commit 5afd131 into salesagility:hotfix Jan 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google API Token for calendar sync in User Profile not working
5 participants