improvement: split generate SBOM & check licenses #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NyanKiyoshi
commented
Oct 11, 2024
There was a problem hiding this comment.
Note: there are no changes in this file except the addition of is_same_repository in order to simplify the checks, e.g.:
Before:
if: ${{ endsWith(github.repository, /saleor-internal-actions) }}
# ...
if: ${{ !endsWith(github.repository, /saleor-internal-actions) }}After:
if: ${{ inputs.is_same_repository }}
# ...
if: ${{ !inputs.is_same_repository }}
patrys
approved these changes
Oct 11, 2024
This splits the SBOM & License Check jobs into a re-usable workflow in order to make it easier to run these two tasks together.
This is needed in order to not introduce lots of duplications (and complexity) when we will be implementing differential checking (base branch vs head branch), as we will be able to trigger the `run-generate-sbom-and-check-licenses.yaml` workflow both on base and head with only a few lines (instead of having many lines in order to generate SBOM, check licenses, etc.)
There are no changes in `run-generate-sbom-and-check-licenses.yaml` **except** the addition of `is_same_repository` in order to simplify the checks e.g., previously we had: `if: ${{ endsWith(github.repository, /saleor-internal-actions) }}`, now we have: `if: ${{ inputs.is_same_repository }}`
NyanKiyoshi
force-pushed
the
enhancement/split-generate-sbom-and-license-check-workflow
branch
from
fbc3c0f
to
866f491
Compare
NyanKiyoshi
deleted the
enhancement/split-generate-sbom-and-license-check-workflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the SBOM & License Check jobs into a re-usable workflow in order to make it easier to run these two tasks together.
This is needed in order to not introduce lots of duplications (and complexity) when we will be implementing differential checking (base branch vs head branch), as we will be able to trigger the
run-generate-sbom-and-check-licenses.yamlworkflow both on base and head with only a few lines (instead of having many lines in order to generate SBOM, check licenses, etc.)There are no changes in
run-generate-sbom-and-check-licenses.yamlexcept the addition ofis_same_repositoryin order to simplify the checks, e.g.:Before:
After: