Fix manual capture issues.

[Hanskrogh]

This pull request fixes issues with manual capture:

• On TransactionChargeRequested event, actions should be returned based on response, to ensure actions on the transaction is correctly updated..
• payment_intent.succeeded shouldn't be used in a manual capture setup.
• amount_capturable_updated event should be used to set TransactionEventTypeEnum.AuthorizationSuccess instead of TransactionEventTypeEnum.AuthorizationAdjustment as per stripe documentation https://docs.stripe.com/payments/payment-intents/verifying-status.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5bbe17d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

@Hanskrogh is attempting to deploy a commit to the Saleor Commerce Team on Vercel.

A member of the Team first needs to authorize it.

[CLAassistant]

All committers have signed the CLA.

[witoszekdev]

Thanks @Hanskrogh for your contribution to Saleor 😄
I've left a few comments, since I wasn't sure your changes will fully address the issue with authorizations / manualCapture please let me know what you think

[witoszekdev]

Suggested change

if (manualCapture) break;

In Stripe docs: the succeeded status for PaymentIntent is sent only when funds are in the account, i.e. captured. The capture could have used manual capture method, but this doesn't matter for this event. I think we should just remove this condition.

[Hanskrogh]

Hi @witoszekdev :)

If you would like to omit this line, I believe we should change the response action of TransactionChargeRequested event in salor, maybe allowing CHARGE_REQUEST as result response?

Otherwise a transaction event with same pspReference and action is going to be fired, which would cause an error.

As it is working right now, the following happens:
TransactionChargeRequested -> stripe app captures the amount in stripe -> sends response back to saleor, which creates the transaction event "CHARGE_SUCCESS".

As a race-condition the "payment_intent_succeded" event form stripe is fired, which then duplicates the "CHARGE_SUCCESS" transaction event.

I believe the best approach, would be to change the logic in saleor to only allow CHARGE_FAILED or CHARGE_REQUESTED results types and then let the app handle everything through webhooks. This would streamline the process with automatic_capture.

But I am not really a python dev, so I can't really change the logic inside saleor... :/

Let me know what you think?

[Hanskrogh]

I am not even sure that the CHARGE_REQUESTED would resolve the case, as the race condition still exists between wether the payment_intent.suceeded or saleor adds the transaction event first :)

[witoszekdev]

This one is a bit tricky - if this is the first Authorization, then AuthorizationSuccess event is fine, but in case the Authorization amount was incremented we might need to use AuthorizationAdjustment event type. This is because Saleor doesn't allow updating the Authorization any other way (AuthorizationSuccess with different amount than previously reported event would result in an exception).

manualCapture from my understanding, won't be a gauge whether this was a first authorzation, or if it was incremented. According to Stripe docs we should check amount_updates on Charge object to determine this.

[witoszekdev]

Let's not remove this file :)

[Hanskrogh]

My fault :)