Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downshift disabled errors #863

Closed
wants to merge 2 commits into from
Closed

Fix downshift disabled errors #863

wants to merge 2 commits into from

Conversation

Cloud11PL
Copy link
Member

I want to merge this change because it fixes the following warning when using combobox:

Passing "disabled" as an argument to getItemProps is not supported anymore. Please use the isItemDisabled prop from useCombobox.

Screenshots

Pull Request Checklist

  • New components are exported from ./src/components/index.ts.
  • The storybook story is created and documentation is properly generated.
  • New component is wrapped in forwardRef.

@Cloud11PL Cloud11PL added the release dev tag Release pkg to npm with @dev tag label Oct 1, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 66ff78f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/macaw-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
macaw-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 8:27am

@Cloud11PL Cloud11PL added release dev tag Release pkg to npm with @dev tag and removed release dev tag Release pkg to npm with @dev tag labels Oct 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20241001083740.

Install it with:

pnpm add @saleor/[email protected]

@Cloud11PL Cloud11PL marked this pull request as ready for review October 4, 2024 10:28
@Cloud11PL Cloud11PL requested a review from a team as a code owner October 4, 2024 10:28
@Cloud11PL Cloud11PL requested review from krzysztofzuraw and lkostrowski and removed request for a team October 4, 2024 10:28
@github-actions GitHub Actions
Copy link
Contributor

This pull request is stale because it has been open 14 days with no activity.

@github-actions github-actions bot added the stale label Oct 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR request has been closed because it has been stalled for 2 days with no activity. You are still welcome to reopen it and continue from where you finished. Best regards Saleor team

@github-actions github-actions bot closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzysztofzuraw krzysztofzuraw Awaiting requested review from krzysztofzuraw krzysztofzuraw is a code owner automatically assigned from saleor/ui-guild

@lkostrowski lkostrowski Awaiting requested review from lkostrowski lkostrowski is a code owner automatically assigned from saleor/ui-guild

Assignees
No one assigned
Labels
release dev tag Release pkg to npm with @dev tag stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Cloud11PL