Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Node version #845

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Change Node version #845

merged 3 commits into from
Aug 27, 2024

Conversation

Cloud11PL
Copy link
Member

I want to merge this change because...

This PR closes #...

Screenshots

Pull Request Checklist

  • New components are exported from ./src/components/index.ts.
  • The storybook story is created and documentation is properly generated.
  • New component is wrapped in forwardRef.

@vercel Vercel
Copy link

vercel bot commented Aug 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
macaw-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 0:08am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: befceb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/macaw-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Cloud11PL Cloud11PL added the release dev tag Release pkg to npm with @dev tag label Aug 27, 2024
@Cloud11PL Cloud11PL added release dev tag Release pkg to npm with @dev tag and removed release dev tag Release pkg to npm with @dev tag labels Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240827095650.

Install it with:

pnpm add @saleor/[email protected]

@Cloud11PL Cloud11PL added release dev tag Release pkg to npm with @dev tag and removed release dev tag Release pkg to npm with @dev tag labels Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240827110916.

Install it with:

pnpm add @saleor/[email protected]

@Cloud11PL Cloud11PL added release dev tag Release pkg to npm with @dev tag and removed release dev tag Release pkg to npm with @dev tag labels Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240827111751.

Install it with:

pnpm add @saleor/[email protected]

poulch
poulch reviewed Aug 27, 2024
View reviewed changes
package.json Outdated
"node": ">=20",
"pnpm": ">=9"
"node": "18 || 20",
"pnpm": ">=8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pnpm version stays without change

Suggested change
"pnpm": ">=8"
"pnpm": ">=9"

@Cloud11PL Cloud11PL added release dev tag Release pkg to npm with @dev tag and removed release dev tag Release pkg to npm with @dev tag labels Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240827113943.

Install it with:

pnpm add @saleor/[email protected]

@Cloud11PL Cloud11PL changed the title Downgrade pnpm Change Node version Aug 27, 2024
@Cloud11PL Cloud11PL marked this pull request as ready for review August 27, 2024 11:54
@Cloud11PL Cloud11PL requested a review from a team as a code owner August 27, 2024 11:54
@Cloud11PL Cloud11PL requested review from krzysztofzuraw and poulch and removed request for a team August 27, 2024 11:54
@Cloud11PL
Copy link
Member Author

Dashboard PR: saleor/saleor-dashboard#5132

@krzysztofzuraw
Copy link
Member

https://github.com/saleor/macaw-ui/blob/main/.nvmrc#L1 this file needs changes as well 😄

@Cloud11PL
Copy link
Member Author

@krzysztofzuraw done :)

@Cloud11PL Cloud11PL merged commit d8516d5 into main Aug 27, 2024
10 checks passed
@Cloud11PL Cloud11PL deleted the downgrade-pnpm branch August 27, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzysztofzuraw krzysztofzuraw krzysztofzuraw approved these changes

@poulch poulch poulch approved these changes

Assignees
No one assigned
Labels
release dev tag Release pkg to npm with @dev tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cloud11PL @krzysztofzuraw @poulch