Export radio indicator #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 68abcaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
poulch
previously approved these changes
Mar 6, 2024
krzysztofzuraw
requested changes
Mar 11, 2024
| export const RadioGroupIndicator = forwardRef< | ||
| HTMLDivElement, | ||
| RadioGroupIndicatorProps | ||
| >(({ disabled, asChild }, ref) => { |
There was a problem hiding this comment.
Question: Won't types be wrong here?
I mean you can use any type from Box but we need to spread the rest of ...props on svg component 🤔
krzysztofzuraw
approved these changes
Mar 11, 2024
poulch
approved these changes
Mar 15, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it exports radio indicator, allowing for custom radio group implementations - right now we need radio tiles in the dashboard.
Screenshots
Pull Request Checklist
./src/components/index.ts.forwardRef.