Handle undefined onChange and remove undefined from formEventTypeAdapter

saleor · Aug 20, 2024 · 9afbcc9 · 9afbcc9
1 parent 14b8d0b
commit 9afbcc9
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 6 deletions.
diff --git a/src/components/Combobox/Dynamic/DynamicCombobox.tsx b/src/components/Combobox/Dynamic/DynamicCombobox.tsx
@@ -141,7 +141,9 @@ const DynamicComboboxInner = <T extends Option>(
  disabled={disabled}
  {...props}
  {...inputProps}
- onChange={formEventTypeAdapter(inputProps.onChange)}
+ onChange={
+ inputProps.onChange && formEventTypeAdapter(inputProps.onChange)
+ }
  />
 
  {endAdornment && typed && <Box>{endAdornment(value)}</Box>}

diff --git a/src/components/Combobox/Static/Combobox.tsx b/src/components/Combobox/Static/Combobox.tsx
@@ -133,7 +133,9 @@ const ComboboxInner = <T extends Option, V extends Option | string>(
  title={isString(value) ? value : value?.label}
  {...props}
  {...inputProps}
- onChange={formEventTypeAdapter(inputProps.onChange)}
+ onChange={
+ inputProps.onChange && formEventTypeAdapter(inputProps.onChange)
+ }
  />
 
  {endAdornment && typed && <Box>{endAdornment(value)}</Box>}

diff --git a/src/components/Multiselect/Dynamic/DynamicMultiselect.tsx b/src/components/Multiselect/Dynamic/DynamicMultiselect.tsx
@@ -188,7 +188,9 @@ const DynamicMultiselectInner = <T extends Option>(
  visibility={showInput ? "visible" : "hidden"}
  {...inputProps}
  {...props}
- onChange={formEventTypeAdapter(inputProps.onChange)}
+ onChange={
+ inputProps.onChange && formEventTypeAdapter(inputProps.onChange)
+ }
  />
  </MultiselectWrapper>
 

diff --git a/src/components/Multiselect/Static/Multiselect.tsx b/src/components/Multiselect/Static/Multiselect.tsx
@@ -177,7 +177,9 @@ const MultiselectInner = <T extends Option, V extends Option | string>(
  visibility={showInput ? "visible" : "hidden"}
  {...inputProps}
  {...props}
- onChange={formEventTypeAdapter(inputProps.onChange)}
+ onChange={
+ inputProps.onChange && formEventTypeAdapter(inputProps.onChange)
+ }
  />
  </MultiselectWrapper>
 

diff --git a/src/utils/formEventTypeAdapter.ts b/src/utils/formEventTypeAdapter.ts
@@ -1,7 +1,8 @@
 import { ChangeEventHandler, FormEventHandler } from "react";
 
+// There is mismatch between desert box onChange type and downshift on change event
 export const formEventTypeAdapter = (
- event: ChangeEventHandler<Element> | undefined
-): FormEventHandler | undefined => {
+ event: ChangeEventHandler<Element>
+): FormEventHandler => {
  return event;
 };