Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent save data in apl when data already exists #365

Closed
wants to merge 2 commits into from

Conversation

poulch
Copy link
Member

@poulch poulch commented Aug 27, 2024

No description provided.

Copy link

changeset-bot bot commented Aug 27, 2024

⚠️ No Changeset found

Latest commit: bd23bca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Package Line Rate Branch Rate Complexity Health
src 79% 93% 0
src.APL 85% 85% 0
src.APL.saleor-cloud 75% 86% 0
src.APL.vercel-kv 54% 69% 0
src.app-bridge 88% 86% 0
src.handlers.next 89% 83% 0
src.handlers.next.saleor-webhooks 94% 80% 0
src.middleware 60% 97% 0
src.settings-manager 96% 89% 0
src.test-utils 100% 90% 0
src.util 82% 100% 0
Summary 83% (3842 / 4616) 86% (455 / 526) 0

Copy link
Member

@lkostrowski lkostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. this will prevent all installations except first to work, because APL is not pruned after app is uninstalled
  2. overwriting APL is something we want
  3. users can't install 2 apps with the same id, so this case should not happen (except old installations)

@poulch poulch closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants