Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create sparate export for vercel kv apl #323

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

lkostrowski
Copy link
Member

@lkostrowski lkostrowski commented Dec 6, 2023

having index.ts that exports all APLs means that all files are evaluated, no matter which apl is included.

it causes app to break because of missing dependency of vercel kv, even is its not used

@lkostrowski lkostrowski requested a review from a team December 6, 2023 14:30
Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: 3de111b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/app-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20231206143126

Install it with

pnpm add @saleor/[email protected]

@lkostrowski lkostrowski force-pushed the change-vercelkv-apl-export-path branch from 211d002 to 3de111b Compare December 6, 2023 14:31
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20231206143209

Install it with

pnpm add @saleor/[email protected]

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Package Line Rate Branch Rate Complexity Health
src 79% 95% 0
src.APL 85% 85% 0
src.APL.saleor-cloud 71% 86% 0
src.APL.vercel-kv 52% 69% 0
src.app-bridge 88% 86% 0
src.handlers.next 90% 85% 0
src.handlers.next.saleor-webhooks 94% 80% 0
src.middleware 60% 97% 0
src.settings-manager 96% 89% 0
src.test-utils 100% 90% 0
src.util 76% 100% 0
Summary 83% (3669 / 4396) 87% (430 / 495) 0

@lkostrowski lkostrowski enabled auto-merge (squash) December 6, 2023 14:54
@lkostrowski lkostrowski merged commit d72d21b into main Dec 6, 2023
5 checks passed
@lkostrowski lkostrowski deleted the change-vercelkv-apl-export-path branch December 6, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants