Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache to CloudAPL #312

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Add cache to CloudAPL #312

merged 2 commits into from
Dec 1, 2023

Conversation

lkostrowski
Copy link
Member

No description provided.

@lkostrowski lkostrowski requested a review from a team December 1, 2023 11:44
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 51cb611

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/app-sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

witoszekdev
witoszekdev requested changes Dec 1, 2023
View reviewed changes
Copy link
Member

@witoszekdev witoszekdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just add a debug when returning data from cache

src/APL/saleor-cloud/saleor-cloud-apl.ts Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20231201124437

Install it with

pnpm add @saleor/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Package Line Rate Branch Rate Complexity Health
src 79% 95% 0 ✔
src.APL 85% 85% 0 ✔
src.APL.saleor-cloud 71% 83% 0 ➖
src.app-bridge 88% 86% 0 ✔
src.handlers.next 90% 85% 0 ✔
src.handlers.next.saleor-webhooks 94% 80% 0 ✔
src.middleware 60% 97% 0 ➖
src.settings-manager 96% 89% 0 ✔
src.test-utils 100% 90% 0 ✔
src.util 76% 100% 0 ✔
Summary 84% (3577 / 4238) 87% (416 / 477) 0 ✔

@lkostrowski lkostrowski enabled auto-merge (squash) December 1, 2023 13:05
@lkostrowski lkostrowski merged commit 09b9185 into main Dec 1, 2023
5 checks passed
@lkostrowski lkostrowski deleted the cloud-apl-cache branch December 1, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@witoszekdev witoszekdev witoszekdev approved these changes

Assignees

@lkostrowski lkostrowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkostrowski @witoszekdev