-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark query in manifest required #280
Conversation
🦋 Changeset detectedLatest commit: f7dedce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Released snapshot build with Install it with pnpm add @saleor/[email protected] |
verify if notify webhook works |
@krzysztofwolski I checked E&M and it looks fine
it defines query as string which is ok for the new SDK |
17a083f
to
b21c06f
Compare
Released snapshot build with Install it with pnpm add @saleor/[email protected] |
.changeset/tender-news-do.md
Outdated
In AppManifest, webhook query field is not required. Saleor rejects empty query, so Manifest was wrong before with with field optional | ||
|
||
This is technically a breaking change, but app without a query specified couldn't be installed in Saleor. | ||
|
||
Now Typescript will early show the error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't explicitly say what the change is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rewrtitten
Released snapshot build with Install it with pnpm add @saleor/[email protected] |
|
In AppManifest, webhook query field is not required. Saleor rejects empty query, so Manifest was wrong before with with field optional
This is technically a breaking change, but app without a query specified couldn't be installed in Saleor.
Now Typescript will early show the error