Fix data serialization in the UpstashAPL (#228)

saleor · Apr 12, 2023 · 5a68bec · 5a68bec
1 parent 5057d34
commit 5a68bec
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/.changeset/eight-wombats-drop.md b/.changeset/eight-wombats-drop.md
@@ -0,0 +1,5 @@
+---
+"@saleor/app-sdk": patch
+---
+
+Fix serialization of the nested values in the UpstashAPL.
diff --git a/src/APL/upstash-apl.test.ts b/src/APL/upstash-apl.test.ts
@@ -57,8 +57,7 @@ describe("APL", () => {
           "https://example.com",
 
           {
-            // eslint-disable-next-line quotes
-            body: `["SET", "${stubAuthData.saleorApiUrl}", "${JSON.stringify(stubAuthData)}"]`,
+            body: JSON.stringify(["SET", stubAuthData.saleorApiUrl, JSON.stringify(stubAuthData)]),
             headers: {
               "Content-Type": "application/json",
               Authorization: "Bearer token",

diff --git a/src/APL/upstash-apl.ts b/src/APL/upstash-apl.ts
@@ -54,7 +54,7 @@ export class UpstashAPL implements APL {
     this.restToken = restToken;
   }
 
-  private async upstashRequest(requestBody: string) {
+  private async upstashRequest(request: string[]) {
     debug("Sending request to Upstash");
     if (!this.restURL || !this.restToken) {
       throw new Error(
@@ -66,7 +66,7 @@ export class UpstashAPL implements APL {
       response = await fetch(this.restURL, {
         method: "POST",
         headers: { "Content-Type": "application/json", Authorization: `Bearer ${this.restToken}` },
-        body: requestBody,
+        body: JSON.stringify(request),
       });
     } catch (error) {
       debug("Error during sending the data:", error);
@@ -97,17 +97,17 @@ export class UpstashAPL implements APL {
     });
 
     const data = JSON.stringify(authData);
-    await this.upstashRequest(`["SET", "${authData.saleorApiUrl}", "${data}"]`);
+    await this.upstashRequest(["SET", authData.saleorApiUrl, data]);
   }
 
   private async deleteDataFromUpstash(saleorApiUrl: string) {
-    await this.upstashRequest(`["DEL", "${saleorApiUrl}"]`);
+    await this.upstashRequest(["DEL", saleorApiUrl]);
   }
 
   private async fetchDataFromUpstash(saleorApiUrl: string) {
-    const result = await this.upstashRequest(`["GET", "${saleorApiUrl}"]`);
+    const result = await this.upstashRequest(["GET", saleorApiUrl]);
     if (result) {
-      const authData = JSON.parse(result);
+      const authData = JSON.parse(result) as AuthData;
       return authData;
     }
     return undefined;