Remove otel HTTP_METHOD attributes

saleor · Jan 5, 2024 · 5a613ed · 5a613ed
1 parent e1fd515
commit 5a613ed
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.changeset/chatty-cherries-begin.md b/.changeset/chatty-cherries-begin.md
@@ -0,0 +1,5 @@
+---
+"@saleor/app-sdk": patch
+---
+
+Removed HTTP_METHOD OTEL attributes. They broke displaying of resources when other attributes related to HTTP are not set.
diff --git a/src/APL/vercel-kv/vercel-kv-apl.ts b/src/APL/vercel-kv/vercel-kv-apl.ts
@@ -40,7 +40,6 @@ export class VercelKvApl implements APL {
         attributes: {
           saleorApiUrl,
           [SemanticAttributes.PEER_SERVICE]: OTEL_APL_SERVICE_NAME,
-          [SemanticAttributes.HTTP_METHOD]: "GET",
         },
         kind: SpanKind.CLIENT,
       },
@@ -91,7 +90,6 @@ export class VercelKvApl implements APL {
           saleorApiUrl: authData.saleorApiUrl,
           appId: authData.appId,
           [SemanticAttributes.PEER_SERVICE]: OTEL_APL_SERVICE_NAME,
-          [SemanticAttributes.HTTP_METHOD]: "POST",
         },
         kind: SpanKind.CLIENT,
       },
@@ -133,7 +131,6 @@ export class VercelKvApl implements APL {
         attributes: {
           saleorApiUrl,
           [SemanticAttributes.PEER_SERVICE]: OTEL_APL_SERVICE_NAME,
-          [SemanticAttributes.HTTP_METHOD]: "DELETE",
         },
         kind: SpanKind.CLIENT,
       },