New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in _score() method of Meteor class #10

Open

doiken23 wants to merge 2 commits into salaniz:master from doiken23:master

doiken23 commented Nov 30, 2020

I fixed 2 bugs in _score() function of Meteor class.

add .encode() and .decode() to stdiin and stdout functions, respectively.
remove overlapped line

for the 2nd bug fix, please see the discussion in https://github.com/jcjohnson/densecap/blob/master/eval/meteor_bridge.py#L42-L46

doiken23 added 2 commits

November 30, 2020 17:57


          🐛 fix encode/decode bug in _score()

a0627e3


          🐛 remove overlapped line

7f86b26

jiahuei commented Jan 6, 2021

The _score() function is not used by METEOR at all, and can be safely removed.
Thus, the bugs are actually not relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet