Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force focus on url field #270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kimmoli
Copy link

@kimmoli kimmoli commented Jan 10, 2015

The virtual keyboard annoyingly blocks access to favorites, and getting rid of it requires swiping down.
Just to keep virtual keyboard hidden until url field is clicked.
Still forces focus when searching on page.

@rainemak
Copy link
Member

Thanks @kimmoli for your first PR.

Alternatively you can close virtual keyboard by panning the favorite list.

Personally I'd like it more like it is now and this is what was requested by design. But I see the point that when using heavily favorites current approach might be annoying. At some point of time we had a pull up gesture for the toolbar to open the overlay and with the gesture we could have skipped focusing of the search field.

Will check this with design again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants