Skip to content

Commit

Permalink
[SPARK-41587][BUILD] Upgrade org.scalatestplus:selenium-4-4 to `org…
Browse files Browse the repository at this point in the history
….scalatestplus:selenium-4-7`

### What changes were proposed in this pull request?
This pr aims upgrade `org.scalatestplus:selenium-4-4` to `org.scalatestplus:selenium-4-7`:

- `org.scalatestplus:selenium-4-4` -> `org.scalatestplus:selenium-4-7`
- `selenium-java`: 4.4.0 -> 4.7.1
- `htmlunit-driver`: 3.64.0 -> 4.7.0
- `htmlunit` -> 2.64.0 -> 2.67.0

And all upgraded dependencies versions are matched.

### Why are the changes needed?
The release notes as follows:

- https://github.com/scalatest/scalatestplus-selenium/releases/tag/release-3.2.14.0-for-selenium-4.7

### Does this PR introduce _any_ user-facing change?
No, just for test

### How was this patch tested?

- Pass Github Actions
- Manual test:
   - ChromeUISeleniumSuite

```
build/sbt -Dguava.version=31.1-jre -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver -Dtest.default.exclude.tags="" -Phive -Phive-thriftserver "core/testOnly org.apache.spark.ui.ChromeUISeleniumSuite"
```

```
[info] ChromeUISeleniumSuite:
Starting ChromeDriver 108.0.5359.71 (1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359{apache#1016}) on port 13600
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.
[info] - SPARK-31534: text for tooltip should be escaped (2 seconds, 702 milliseconds)
[info] - SPARK-31882: Link URL for Stage DAGs should not depend on paged table. (824 milliseconds)
[info] - SPARK-31886: Color barrier execution mode RDD correctly (313 milliseconds)
[info] - Search text for paged tables should not be saved (1 second, 745 milliseconds)
[info] Run completed in 10 seconds, 266 milliseconds.
[info] Total number of tests run: 4
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 4, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 23 s, completed 2022-12-19 19:41:26
```

   - RocksDBBackendChromeUIHistoryServerSuite

```
build/sbt -Dguava.version=31.1-jre -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver -Dtest.default.exclude.tags="" -Phive -Phive-thriftserver "core/testOnly org.apache.spark.deploy.history.RocksDBBackendChromeUIHistoryServerSuite"
```

```
[info] RocksDBBackendChromeUIHistoryServerSuite:
Starting ChromeDriver 108.0.5359.71 (1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359{apache#1016}) on port 2201
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.
[info] - ajax rendered relative links are prefixed with uiRoot (spark.ui.proxyBase) (2 seconds, 362 milliseconds)
[info] Run completed in 10 seconds, 254 milliseconds.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 24 s, completed 2022-12-19 19:40:42
```

Closes apache#39129 from LuciferYang/selenium-47.

Authored-by: yangjie01 <[email protected]>
Signed-off-by: Kousuke Saruta <[email protected]>
  • Loading branch information
LuciferYang authored and sarutak committed Dec 21, 2022
1 parent 7efc6f4 commit ee2e582
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,9 @@
<!-- Please don't upgrade the version to 4.10+, it depends on JDK 11 -->
<antlr4.version>4.9.3</antlr4.version>
<jpam.version>1.1</jpam.version>
<selenium.version>4.4.0</selenium.version>
<htmlunit-driver.version>3.64.0</htmlunit-driver.version>
<htmlunit.version>2.64.0</htmlunit.version>
<selenium.version>4.7.1</selenium.version>
<htmlunit-driver.version>4.7.0</htmlunit-driver.version>
<htmlunit.version>2.67.0</htmlunit.version>
<maven-antrun.version>1.8</maven-antrun.version>
<commons-crypto.version>1.1.0</commons-crypto.version>
<commons-cli.version>1.5.0</commons-cli.version>
Expand Down Expand Up @@ -416,7 +416,7 @@
</dependency>
<dependency>
<groupId>org.scalatestplus</groupId>
<artifactId>selenium-4-4_${scala.binary.version}</artifactId>
<artifactId>selenium-4-7_${scala.binary.version}</artifactId>
<scope>test</scope>
</dependency>
<dependency>
Expand Down Expand Up @@ -1144,7 +1144,7 @@
</dependency>
<dependency>
<groupId>org.scalatestplus</groupId>
<artifactId>selenium-4-4_${scala.binary.version}</artifactId>
<artifactId>selenium-4-7_${scala.binary.version}</artifactId>
<version>3.2.14.0</version>
<scope>test</scope>
</dependency>
Expand Down

0 comments on commit ee2e582

Please sign in to comment.