Reproduce Load controller + Fix with new API #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Fine for me. Should we change all load_* tests to use empty parameter files?
And do we now have an explanation why the current rolling version failed with a correct yaml, as described with ros-controls#795?
| @@ -43,6 +42,10 @@ controller_interface::CallbackReturn IMUSensorBroadcaster::on_init() | |||
| controller_interface::CallbackReturn IMUSensorBroadcaster::on_configure( | |||
| const rclcpp_lifecycle::State & /*previous_state*/) | |||
| { | |||
| if (!param_listener_->are_params_initialized()) | |||
There was a problem hiding this comment.
do we need this in the client code, or should we put this in the library?
There was a problem hiding this comment.
I think it won't be needed for sure if you call the initialize_parameters on the first instance. If the get_params is called, then it throws an exception anyway.
We can remove the check if you prefer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs: saikishor/generate_parameter_library#1