Skip to content

Commit

Permalink
release
Browse files Browse the repository at this point in the history
  • Loading branch information
@sagiegurari
sagiegurari committed Apr 13, 2020
1 parent d3eb555 commit ee57877
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ See [contributing guide](.github/CONTRIBUTING.md)

| Date | Version | Description |
| ----------- | ------- | ----------- |
| 2020-01-30 | v2.9.0 | Upgrade markdownlint version |
| 2020-04-13 | v2.10.0 | Upgrade markdownlint version |
| 2018-06-07 | v2.0.0 | Upgrade markdownlint and minimal node version |
| 2018-05-29 | v1.1.6 | Upgrade markdownlint version |
| 2016-11-04 | v1.0.11 | Support new markdownlint 0.3.0 options |
Expand Down
2 changes: 1 addition & 1 deletion docs/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
| Date | Version | Description |
| ----------- | ------- | ----------- |
| 2020-01-30 | v2.9.0 | Upgrade markdownlint version |
| 2020-04-13 | v2.10.0 | Upgrade markdownlint version |
| 2018-06-07 | v2.0.0 | Upgrade markdownlint and minimal node version |
| 2018-05-29 | v1.1.6 | Upgrade markdownlint version |
| 2016-11-04 | v1.0.11 | Support new markdownlint 0.3.0 options |
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "grunt-markdownlint",
"version": "2.9.0",
"version": "2.10.0",
"description": "A grunt task for markdown style checker and lint tool.",
"author": {
"name": "Sagie Gur-Ari",
Expand Down

3 comments on commit ee57877

@DavidAnson
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagiegurari If a release of this package contains a semver-breaking change to the markdownlint library, maybe the next release of this package should also be breaking? Otherwise, users of this package may see a break unexpectedly. What do you think?

@sagiegurari
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidAnson makes sense.
since you are <1 i guess you update the minor version only on breaking change? in which can i'll update my major version as i'm >1 version. but just want to be sure you are not upgrading minor version of non breaking stuff...

@DavidAnson
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree with what you suggest.

To explain, the most recent release of the library has a regression that showed up unexpectedly for some people. Most projects are not set up to take breaking changes in dependencies automatically, so this was a bit surprising. In one case, it looks like maybe they used your project and automatically updated to the latest release which contained the breaking change in the library. There’s nothing to do about it now, but something to think about for next time.

Thank you!

Please sign in to comment.